Add Radshid 2G/4G protocol support #5583
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tananaev
reviewed
Jun 11, 2025
tananaev
reviewed
Jun 11, 2025
Comment on lines
+147
to
+152
| byte ioStatus = packetData.readByte(); // IO Status | ||
| byte gpsStatus = packetData.readByte(); // GPS Status | ||
| long latitude = packetData.readInt(); // Latitude | ||
| long longitude = packetData.readInt(); // Longitude | ||
| int altitude = packetData.readShort(); //Altitude | ||
| int bearing = packetData.readShort(); //Bearing |
There was a problem hiding this comment.
Remove unnecessary variables and comments.
tananaev
reviewed
Jun 11, 2025
| import java.util.LinkedList; | ||
| import java.util.List; | ||
|
|
||
| public class RadshidProtocolDecoder extends BaseProtocolDecoder { |
There was a problem hiding this comment.
You also have to add unit tests for the protocol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch was opened last year but I didn’t have time to finish it until now. I finally revisited the code, fixed several wording / formatting issues in the docs and comments, and made sure everything builds cleanly against the current
master.
Radshid is a company that make 2G/4G trackers, I added the radshid protocol to traccar.
you can find Radshid protocol on #5235.