Bugfix: Add VGN mode parameter #5523
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Looks like existing tests are failing. |
|
Ehh realized that when it broke IGN for some devices. Updated. |
tananaev
reviewed
Mar 12, 2025
| Map.entry("BD", "CV200"), | ||
| Map.entry("C2", "GV600M"), | ||
| Map.entry("DC", "GV600MG"), | ||
| Map.entry("DE", "GL500M"), | ||
| Map.entry("F1", "GV350M"), | ||
| Map.entry("F8", "GV800W"), | ||
| Map.entry("FC", "GV600W"), | ||
| Map.entry("FE", "GV53MG"), |
There was a problem hiding this comment.
Please attach full documentation for both device models.
tananaev
reviewed
Mar 12, 2025
| @@ -1074,6 +1077,11 @@ private Object decodeIgn( | |||
| return position; | |||
| } | |||
|
|
|||
| private boolean isVirtualIgnitionMode(String type, String model) { | |||
There was a problem hiding this comment.
I don't think we need a separate function for this. Also what does type.contains("VG") mean?
tananaev
reviewed
Mar 12, 2025
| @@ -1074,6 +1077,11 @@ private Object decodeIgn( | |||
| return position; | |||
| } | |||
|
|
|||
| private boolean isVirtualIgnitionMode(String type, String model) { | |||
| return type.contains("VG") && | |||
| List.of("GV50M", "GV53MG").contains(model); | |||
There was a problem hiding this comment.
A set of direct comparison would make more sense here.
tananaev
reviewed
Mar 12, 2025
| @@ -61,6 +61,9 @@ public void testDecode() throws Exception { | |||
| "+RESP:GTVGN,C2010D,869653060009939,GV600M,453966,0,0.0,0,163.9,10.239379,45.931389,20231210233723,0222,0010,2F31,006D7621,,,0.0,20240107182623,143F$"), | |||
| Position.KEY_IGNITION, true); | |||
|
|
|||
| verifyPosition(decoder, buffer( | |||
There was a problem hiding this comment.
Please add new test to the top of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GV50M tracker was flipping Online - in a minute due to NumberFormatException in decodeIgn's parsing of position data.
The root cause was a missing index += 1 to skip over the virtual ignition mode parameter.