It doesn't look like all of the comments from last PR were addressed.

Also maybe it would be easier to split it into several PRs. For example encoder can be separate from the main decoding.

Hi, I think this is difficult to split because when the server receives a message from the device, it must reply with different response messages, which requires the encoder to encode the corresponding response messages. Therefore, the encoder code cannot be split.

And where exactly are you using encoder for responses? I don't see it.

In ZrProtocolDecoder.java, at lines 89, 92, 96,and 99.

Could you please re-label the suggestions for code modifications? I'm not sure what needs to be changed, and I would greatly appreciate it.

In ZrProtocolDecoder.java, at lines 89, 92, 96,and 99.

It doesn't use encoder. It's the other way around. Did you write this code yourself?

Could you please re-label the suggestions for code modifications? I'm not sure what needs to be changed, and I would greatly appreciate it.

Unfortunately I don't have time. Please check the original PR.

Yes, I wrote the code.When you mentioned encoder, are you referring to ZrProtocolEncoder.java?I just deleted that part of the file.

Thanks. Let me know once all the other issues are resolved, so we can review it again.