-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
issue-#31800-fixed #31813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
issue-#31800-fixed #31813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
@@ -5,14 +5,14 @@ | |||
"keywords": [ | |||
"storybook" | |||
], | |||
"homepage": "https://github.com/storybookjs/storybook/tree/next/code/lib/cli", | |||
"homepage": "https://github.com/storybookjs/storybook/tree/next/code/lib/cli-storybook", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: The homepage path for the sb package should point to 'code/lib/cli-sb' instead of 'code/lib/cli-storybook' since this is the sb package
"homepage": "https://github.com/storybookjs/storybook/tree/next/code/lib/cli-storybook", | |
"homepage": "https://github.com/storybookjs/storybook/tree/next/code/lib/cli-sb", |
"bugs": { | ||
"url": "https://github.com/storybookjs/storybook/issues" | ||
}, | ||
"repository": { | ||
"type": "git", | ||
"url": "https://github.com/storybookjs/storybook.git", | ||
"directory": "code/lib/cli" | ||
"directory": "code/lib/cli-storybook" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: The repository directory for the sb package should be 'code/lib/cli-sb' instead of 'code/lib/cli-storybook' to match its actual location
"directory": "code/lib/cli-storybook" | |
"directory": "code/lib/cli-sb" |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
Before | After | Difference | |
---|---|---|---|
Dependency count | 49 | 49 | 0 |
Self size | 31.85 MB | 31.87 MB | 🚨 +16 KB 🚨 |
Dependency size | 17.41 MB | 17.41 MB | 0 B |
Bundle Size Analyzer | Link | Link |
sb
Before | After | Difference | |
---|---|---|---|
Dependency count | 50 | 50 | 0 |
Self size | 1 KB | 1 KB | 🚨 +20 B 🚨 |
Dependency size | 49.26 MB | 49.27 MB | 🚨 +16 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/cli
Before | After | Difference | |
---|---|---|---|
Dependency count | 216 | 216 | 0 |
Self size | 582 KB | 582 KB | 🚨 +20 B 🚨 |
Dependency size | 94.58 MB | 94.59 MB | 🚨 +16 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/codemod
Before | After | Difference | |
---|---|---|---|
Dependency count | 185 | 185 | 0 |
Self size | 31 KB | 31 KB | 0 B |
Dependency size | 78.71 MB | 78.72 MB | 🚨 +16 KB 🚨 |
Bundle Size Analyzer | Link | Link |
#31800
Problem
The homepage and repository.directory fields in the package.json files of the following packages are incorrectly pointing to code/lib/cli:
@storybook/cli (code/lib/cli-storybook/package.json)
sb (code/lib/cli-sb/package.json)
This causes confusion when navigating the GitHub repository, as the links do not accurately reflect the location of the packages.
Incorrect Values:
homepage: https://github.com/storybookjs/storybook/tree/next/code/lib/cli
repository.directory: code/lib/cli
Fix
Updated both fields to correctly reference code/lib/cli-storybook:
code/lib/cli-storybook/package.json
diff
Copy
Edit
code/lib/cli-sb/package.json
diff
Copy
Edit
Files Affected:
code/lib/cli-storybook/package.json
code/lib/cli-sb/package.json
Checklist:
Updated homepage and repository.directory fields
Verified path accuracy for both packages
No other unrelated changes included
Greptile Summary
Updates package.json metadata fields to fix incorrect directory references, but introduces a new issue. While the PR correctly updates
@storybook/cli
paths fromcode/lib/cli
tocode/lib/cli-storybook
, it incorrectly applies the same path to thesb
package which should point tocode/lib/cli-sb
instead.@storybook/cli
package.json to correctly referencecode/lib/cli-storybook
sb
package incorrectly points tocli-storybook
instead ofcli-sb