Skip to content

React Native Web: Fix shift spread operator in react-native-web-vite presets #31804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

xlecunff-pass
Copy link

@xlecunff-pass xlecunff-pass commented Jun 17, 2025

Closes #31637

What I did

Move the spread operator in the presets of framework @storybook/react-native-web-vite to give complete control to the developer via his Storybook config file

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Fixed Babel configuration in @storybook/react-native-web-vite to properly support react-native-reanimated by adjusting the spread operator placement in preset configuration.

  • Moved spread operator for pluginBabelOptions.babelConfig after default settings in code/frameworks/react-native-web-vite/src/preset.ts
  • Enables developers to override Babel configuration through Storybook config file
  • Resolves export namespace transformation issues with react-native-reanimated
  • Improves configuration control for React Native Web projects

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@dannyhw
Copy link
Member

dannyhw commented Jun 17, 2025

thank you @xlecunff-pass, this seems reasonable to me 👍

@dannyhw dannyhw added maintenance User-facing maintenance tasks ci:normal labels Jun 17, 2025
@dannyhw dannyhw changed the title fix: shift spread operator in react-native-web-vite presets React Native Web: Fix shift spread operator in react-native-web-vite presets Jun 17, 2025
Copy link

nx-cloud bot commented Jun 17, 2025

View your CI Pipeline Execution ↗ for commit 00c3a33.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 14s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-17 18:57:36 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: @storybook/react-native-web not working with react-native-reanimated
2 participants