Core: Enhance package manager install methods to support optional force flag #31796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
6 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit 819607a.
☁️ Nx Cloud last updated this comment at |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
kasperpeulen
approved these changes
Jun 17, 2025
valentinpalkovic
deleted the
valentin/circumvent-npm-peer-dep-error-during-upgrade
branch
32 tasks
valentinpalkovic
added
the
patch:yes
Merged
15 tasks
valentinpalkovic
added a commit
that referenced
this pull request
Jun 17, 2025
…er-dep-error-during-upgrade Core: Enhance package manager install methods to support optional force flag (cherry picked from commit c8f2db1)
15 tasks
github-actions
bot
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
When upgrading dependencies, for npm users we always install dependencies with the
--forceflag set to circumvent the issue described here npm/cli#8059Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-31796-sha-819607ae. Try it out in a new sandbox by runningnpx [email protected] sandboxor in an existing project withnpx [email protected] upgrade.More information
0.0.0-pr-31796-sha-819607aevalentin/circumvent-npm-peer-dep-error-during-upgrade819607ae1750154555)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=31796Greptile Summary
Enhances package manager install methods with a force flag option to address npm peer dependency issues during upgrades, particularly npm/cli#8059.
JsPackageManagerbase class to support optional force flag ininstallDependenciesandrunInstallmethodsupgrade.tsto automatically use --force flag for npm installations