Skip to content

Angular: Fix Storybook experimentalZoneless is not compatible with Angular 20 #31772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

guysenpai
Copy link
Contributor

@guysenpai guysenpai commented Jun 13, 2025

Closes #31652

What I did

Angular 20 has rename the provideExperimentalZonelessChangeDetection to provideZonelessChangeDetection. So we reflects this change to fully support Angular 20.

NOTE: In Angular 20, zoneless is no longer experimental. We should also rename the experimentalZoneless option in STORYBOOK_ANGULAR_OPTIONS to zoneless, but it will introduce a BREAKING CHANGE. To keep compatibility with previous versions we skip this change.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Updates Angular support to handle the renamed zoneless change detection API in Angular 20, maintaining backwards compatibility with Angular 18-19.

  • Modified code/frameworks/angular/src/client/angular-beta/AbstractRenderer.ts to support both provideZonelessChangeDetection (Angular 20+) and provideExperimentalZonelessChangeDetection (Angular 18-19)
  • Maintains experimentalZoneless option name in STORYBOOK_ANGULAR_OPTIONS for backward compatibility
  • Preserves functionality while adapting to Angular 20's non-experimental zoneless implementation
  • Ensures smooth transition for projects using different Angular versions

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile

@guysenpai guysenpai force-pushed the support-angular-20 branch from 921a0be to 573b665 Compare June 13, 2025 08:48
@valentinpalkovic
Copy link
Contributor

LGTM! You're contribution is much appreciated!

Copy link

nx-cloud bot commented Jun 16, 2025

View your CI Pipeline Execution ↗ for commit 0c110cc.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 12s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-16 06:34:05 UTC

@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 16, 2025
@valentinpalkovic valentinpalkovic merged commit 6703f2e into storybookjs:next Jun 16, 2025
54 of 64 checks passed
valentinpalkovic added a commit that referenced this pull request Jun 17, 2025
Angular: fix Storybook experimentalZoneless is not compatible with Angular 20
(cherry picked from commit 6703f2e)
@github-actions github-actions bot mentioned this pull request Jun 17, 2025
7 tasks
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 17, 2025
@shilman shilman changed the title Angular: fix Storybook experimentalZoneless is not compatible with Angular 20 Angular: Fix Storybook experimentalZoneless is not compatible with Angular 20 Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Storybook experimentalZoneless is not compatible with Angular 20
2 participants