WIP (don't merge) #31731
Draft
WIP (don't merge) #31731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit ed64b2c.
☁️ Nx Cloud last updated this comment at |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
yannbf
force-pushed
the
yann/investigation
branch
from
859b6c7 to
9b8dda7
Compare
There was a problem hiding this comment.
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
code/core/src/node-logger/README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # Storybook Logger | |||
|
|
|||
| Any node logging that is done through storybook should be done through this package. | |||
| Any node logging that is done through storybook should be done through this packages. | |||
There was a problem hiding this comment.
syntax: Grammatical error: 'packages' should be singular 'package' since 'logging' is singular
Suggested change
| Any node logging that is done through storybook should be done through this packages. | |
| Any node logging that is done through storybook should be done through this package. |
yannbf
force-pushed
the
yann/investigation
branch
12 times, most recently
from
82be9c4 to
b244f6c
Compare
yannbf
force-pushed
the
yann/investigation
branch
from
b244f6c to
ed64b2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Introduces an unintentional grammatical error in
code/core/src/node-logger/README.mdby changing 'package' to 'packages', making the documentation less accurate.