call rb_warn() if fail to create timer_thread, set system_working=0 #13671
+27
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it is better to run without timer thread even if it has an issue. |
|
Okay, that makes sense. I'll make sure not call Edit: I updated the PR. The failed CI run is due to a flake test. |
luke-gruber
force-pushed
the
rb_bug_if_cant_create_timer_thread
branch
from
acd3477 to
7132323
Compare
luke-gruber
changed the title
luke-gruber
force-pushed
the
rb_bug_if_cant_create_timer_thread
branch
from
7132323 to
339e4ea
Compare
We should do this in general, but there are specific cases that worry me about timer thread creation. In `rb_fork_ruby()`, if the call to `fork` fails, we handle the error (sleep or GC depending on errno), and try again. If fork fails because of resource issues, we can't assume the call in `after_fork_ruby()` to create the timer thread will succeed. If it fails, we get undefined behavior in the next iteration of the loop when we call pthread_join() on it in `before_fork_ruby`. To fix this, we set `system_working = 0` if pthread creation fails.
luke-gruber
force-pushed
the
rb_bug_if_cant_create_timer_thread
branch
from
339e4ea to
0bcf056
Compare
❌ Tests Failed✖️no tests failed ✔️62015 tests passed(1 flake) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should check this in general, but there are specific cases that worry me about timer thread creation.
In
rb_fork_ruby(), if the call toforkfails, we handle the error (sleep or GC depending on errno), and try again. If fork fails because of resource issues, we can't assume the call inafter_fork_ruby()to create the timer thread will succeed. If it fails, we get undefined behavior in the next iteration of the loop when we call pthread_join() on it inbefore_fork_ruby().