Fix load catch table write barrier #13669
Open
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
force-pushed
the
wbcheck_catch_take_take_2
branch
from
61f9843 to
685e874
Compare
I tried fixing this in 521b2fc, but re-running wbcheck with the stricter WBCHECK_VERIFY_AFTER_WB, revealed that this write barrier was fired too early, before the object was actually written to the parent. This solves the issue by writing the table to the parent immediately (and using calloc so that we don't mark random garbage).
jhawthorn
force-pushed
the
wbcheck_catch_take_take_2
branch
from
685e874 to
1a8705c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried fixing this in 521b2fc, but re-running wbcheck with the stricter WBCHECK_VERIFY_AFTER_WB, revealed that this write barrier was fired too early, before the object was actually written to the parent.
This solves the issue by writing the table to the parent immediately (and using calloc so that we don't mark random garbage).