Get transcoding to work across ractors by locking certain operations #13601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ex: `str.encode` and `str.encode!` work across ractors now. I'm not certain that these are all the locks we need, there may be more that I missed. However, it's certainly a lot better than before. I'm not getting anymore segfaults or encoding not found exceptions when running tests inside multiple ractors.
luke-gruber
force-pushed
the
ractor_transcode_lock
branch
from
1f4242d to
1755423
Compare
❌ Tests Failed✖️1 test failed ✔️61990 tests passed(1 flake) 1/166 test sessions failed❌ Test session #4483181 failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ex:
str.encodeandstr.encode!work across ractors now.I'm not certain that these are all the locks we need, there may be more that I missed. However, it's certainly a lot better than before. I'm not getting anymore segfaults or encoding not found exceptions when running tests inside multiple ractors.