-
Notifications
You must be signed in to change notification settings - Fork 5.4k
[Do not merge] wbcheck: Experimental pluggable GC to detect missing write barriers #13557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
❌ Tests Failed✖️6 tests failed ✔️28811 tests passed(5 flakes) 4/86 test sessions failed❌ Test session #4523833 failed ❌ Test session #4523853 failed ❌ Test session #4523880 failed ❌ Test session #4523892 failed |
This reverts commit 1ca55f5.
I don't remember if this was necessary
Because TypedData_Make_Struct both allocates an object and after xmallocs memory, all added references must always be writebarrier protected.
Important
I will not be merging this, at least not any time soon. Not looking for code review, just sharing an experiment early in its development.
I've been working on a tool to help detect missed write barriers more reliably. This is one of the most common, yet for a WB bug to actually surface it requires very specific conditions so it's hard to tell when one exists or even has been fixed.
The basic algorithm is:
a.references = reachable_objects_from(a)
a -> b
-a.references << b
(reachable_objects_from(a) - a.references).empty?
, otherwise we've missed a write barrierI've implemented this by writing a new pluggable GC just for testing and debugging, which applies these checks to every object. These rules might be more strict than the default GC requires, for example WBs that could only happen from young to old objects, however I think it will more reliably reproduce issues. For example this has found a few cases where
initialize
/initialize_copy
was missing write barriers, which is unlikely to cause an issue in practice, but one couldObject.allocate
an object, let it get old, and thenobj.send(:initialize, young_reference)
to cause a crash. I think we should follow the stricter rules to ensure we don't miss any write barriers and to avoid assumptions about the GC implementation.Example usage (finding a real bug in Set! See #13558):
Limitations:
make btest
has about 4 bugs.make test-all
shows a lot of problems, some are likely false positives, but I've found a few seemingly legitimate issues.