Fix update reminders not rescheduling the actual reminder #19252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunopagno
force-pushed
the
fix/64971-update-reminders
branch
from
af88790 to
c979c03
Compare
akabiru
approved these changes
Jun 23, 2025
| @@ -31,17 +31,9 @@ class UpdateService < ::BaseServices::Update | |||
| include Reminders::ServiceHelpers | |||
|
|
|||
| def after_perform(service_call) | |||
| reschedule_reminder(service_call.result) if remind_at_changed? | |||
| reschedule_reminder(service_call.result) if model.saved_change_to_remind_at? | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/communicator-stream/work_packages/64971/activity
What are you trying to accomplish?
As per title
What approach did you choose and why?
Use
saved_change_to_attribute?to check if an object has been updated