Skip to content

Update postgres references #19210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 23, 2025
Merged

Update postgres references #19210

merged 5 commits into from
Jun 23, 2025

Conversation

oliverguenther
Copy link
Member

Extended from #19011

Solves this:

Not sure if this line for handling legacy configs could use some change too.

What are you trying to accomplish?

  • Fix the broken OpenProject 16 Docker (All-in-One and docker compose) PostgreSQL Upgrade.
  • Fix the old OpenProject image version to 16.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@oliverguenther oliverguenther requested a review from machisuji June 17, 2025 10:57
@oliverguenther oliverguenther mentioned this pull request Jun 17, 2025
Closed
3 tasks
@opf opf deleted a comment from github-actions bot Jun 17, 2025
machisuji
machisuji reviewed Jun 17, 2025
View reviewed changes
@oliverguenther oliverguenther force-pushed the update-postgres-references branch from fb0db32 to 43f91b0 Compare June 20, 2025 06:16
@github-actions GitHub Actions
Copy link

Caution

The provided work package version does not match the core version

Details:

Please make sure that:

  • The work package version OR your pull request target branch is correct

machisuji
machisuji reviewed Jun 20, 2025
View reviewed changes
docker/prod/entrypoint.sh Outdated
echo "-----> Existing PostgreSQL cluster found in $PGDATA."

# Check for version mismatch: if Docker default is PG 17 but existing data is PG 13
if [ "$PGVERSION" = "17" ] && [ "$EXISTING_PGVERSION" = "13" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliverguenther Should we perhaps not make this specific to 17 and 13 but show this warning in general if there is a mismatch between the set PGVERSION and the one found in the cluster?

I know coming from our own setups, this should be the only combination really, but it probably doesn't hurt to catch more potential issues here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@machisuji
Copy link
Member

@oliverguenther Since we are now using Postgres 17 to generate the schema cache during the docker build, this failed due to missing permissions. I've pushed a commit that fixes that. With that this should look fine.

I was wondering if the used postgres version has any bearing on the generated schema cache. But it doesn't seem to be a problem for our containers with the pg13-generated schema cache using more recent versions, so I suppose not.

As soon as CI is green this can be merged as far as I'm concerned.

machisuji
machisuji approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@machisuji machisuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverguenther oliverguenther merged commit 1fc574c into dev Jun 23, 2025
11 of 12 checks passed
@oliverguenther oliverguenther deleted the update-postgres-references branch June 23, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machisuji machisuji machisuji approved these changes

Assignees
No one assigned
Labels
needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverguenther @machisuji @3115fcfc-2c0b-4076-927f-ae6531c76061