Skip to content

UCP/WIREUP: Introduce address request/reply wireup messages #10684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+183 −48
Open

UCP/WIREUP: Introduce address request/reply wireup messages #10684

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92e28b6
UCP/WIREUP: Introduce address request/reply wireup messages and refac…
evgeny-leksikov May 13, 2025
e61ba5c
UCP/WIREUP: replace ucp_ep_get_lane with ucp_ep_get_lane_raw where NU…
evgeny-leksikov May 13, 2025
d0f540b
UCP/WIREUP: Introduce address request/reply, CR1
evgeny-leksikov May 15, 2025
828ab1b
UCP/WIREUP: Introduce address request/reply, CR2
evgeny-leksikov May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
UCP/WIREUP: Introduce address request/reply, CR2
  • Loading branch information
@evgeny-leksikov
evgeny-leksikov committed May 16, 2025
commit 828ab1b8a0065947d5c0f1869c53f9f662ad0e6e
24 changes: 7 additions & 17 deletions src/ucp/wireup/wireup.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,20 +931,6 @@ ucp_wireup_create_onetime_reply_ep(
return status;
}

static void ucp_wireup_destroy_onetime_reply_ep(ucp_ep_h ep)
{
ucp_ep_cleanup_lanes(ep);
ucp_ep_delete(ep);
}

static ucs_status_ptr_t ucp_wireup_flush_onetime_reply_ep(ucp_ep_h ep)
{
return ucp_ep_flush_internal(ep, UCP_REQUEST_FLAG_RELEASED,
&ucp_request_null_param, NULL,
ucp_ep_removed_flush_completion,
"close onetime EP", UCT_FLUSH_FLAG_LOCAL);
}

static void ucp_wireup_send_reply_on_onetime_ep(
ucp_worker_h worker, const ucp_wireup_msg_t *msg, uint8_t msg_type,
const ucp_unpacked_address_t *remote_address)
Expand Down Expand Up @@ -978,12 +964,16 @@ static void ucp_wireup_send_reply_on_onetime_ep(
goto out_destroy_ep;
}

if (UCS_PTR_IS_PTR(ucp_wireup_flush_onetime_reply_ep(reply_ep))) {
if (UCS_PTR_IS_PTR(ucp_ep_flush_internal(reply_ep,
UCP_REQUEST_FLAG_RELEASED, &ucp_request_null_param, NULL,
ucp_ep_removed_flush_completion, "close onetime EP",
UCT_FLUSH_FLAG_LOCAL))) {
return;
}

out_destroy_ep:
ucp_wireup_destroy_onetime_reply_ep(reply_ep);
ucp_ep_cleanup_lanes(reply_ep);
ucp_ep_delete(reply_ep);
}

static UCS_F_NOINLINE
Expand Down Expand Up @@ -2074,7 +2064,7 @@ ucs_status_t ucp_wireup_send_request(ucp_ep_h ep, uint8_t msg_type)
ucp_wireup_msg_str(msg_type), ep->flags);
status = ucp_wireup_msg_send(ep, msg_type, &tl_bitmap, NULL);

if (msg_type == UCP_WIREUP_MSG_ADDR_REQUEST) {
if (msg_type == UCP_WIREUP_MSG_REQUEST) {
ucp_ep_update_flags(ep, UCP_EP_FLAG_CONNECT_REQ_QUEUED, 0);
}

Expand Down
Loading