Skip to content

Remove left-over network path references #12446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2024
Merged

Remove left-over network path references #12446

merged 1 commit into from
Sep 7, 2024

Conversation

nielsvanvelzen
Copy link
Member

Although removed in 10.9 we forgot to remove some references to the old network path support. This caused the server to still send these paths in specific cases.

Changes

  • Remove left-over network path references

Issues

@github-actions GitHub Actions
Copy link

Changes in OpenAPI specification found. Expand to see details.

What's Changed

POST /Library/VirtualFolders/Paths
Request:

Changed content type : application/json

Updated MediaPathDto :

  • Changed property PathInfo (object)

    Gets or sets the path info.

    Updated MediaPathInfo :

    • Deleted property NetworkPath (string)

Changed content type : text/json

Updated MediaPathDto :

  • Changed property PathInfo (object)

    Gets or sets the path info.

    Updated MediaPathInfo :

    • Deleted property NetworkPath (string)

Changed content type : application/*+json

Updated MediaPathDto :

  • Changed property PathInfo (object)

    Gets or sets the path info.

    Updated MediaPathInfo :

    • Deleted property NetworkPath (string)
POST /Library/VirtualFolders/Paths/Update
Request:

Changed content type : application/json

Updated UpdateMediaPathRequestDto :

  • Changed property PathInfo (object)

    Gets or sets library folder path information.

    Updated MediaPathInfo :

    • Deleted property NetworkPath (string)

Changed content type : text/json

Updated UpdateMediaPathRequestDto :

  • Changed property PathInfo (object)

    Gets or sets library folder path information.

    Updated MediaPathInfo :

    • Deleted property NetworkPath (string)

Changed content type : application/*+json

Updated UpdateMediaPathRequestDto :

  • Changed property PathInfo (object)

    Gets or sets library folder path information.

    Updated MediaPathInfo :

    • Deleted property NetworkPath (string)
GET /System/Configuration
Return Type:

Changed response : 200 OK

Application configuration returned.

  • Changed content type : application/json

    • Deleted property MetadataNetworkPath (string)

  • Changed content type : application/json; profile="CamelCase"

    • Deleted property MetadataNetworkPath (string)

  • Changed content type : application/json; profile="PascalCase"

    • Deleted property MetadataNetworkPath (string)
POST /System/Configuration
Request:

Changed content type : application/json

Updated ServerConfiguration :

  • Deleted property MetadataNetworkPath (string)

Changed content type : text/json

Updated ServerConfiguration :

  • Deleted property MetadataNetworkPath (string)

Changed content type : application/*+json

Updated ServerConfiguration :

  • Deleted property MetadataNetworkPath (string)
GET /Library/VirtualFolders
Return Type:

Changed response : 200 OK

Virtual folders retrieved.

  • Changed content type : application/json

    Changed items (object):
    > Used to hold information about a user's list of configured virtual folders.

    • Changed property LibraryOptions (object)

      Updated LibraryOptions :

      • Changed property PathInfos (array)

        Changed items (object):

        • Deleted property NetworkPath (string)

  • Changed content type : application/json; profile="CamelCase"

    Changed items (object):
    > Used to hold information about a user's list of configured virtual folders.

    • Changed property LibraryOptions (object)

      Updated LibraryOptions :

      • Changed property PathInfos (array)

        Changed items (object):

        • Deleted property NetworkPath (string)

  • Changed content type : application/json; profile="PascalCase"

    Changed items (object):
    > Used to hold information about a user's list of configured virtual folders.

    • Changed property LibraryOptions (object)

      Updated LibraryOptions :

      • Changed property PathInfos (array)

        Changed items (object):

        • Deleted property NetworkPath (string)
POST /Library/VirtualFolders
Request:

Changed content type : application/json

Updated AddVirtualFolderDto :

  • Changed property LibraryOptions (object)

    Gets or sets library options.

    Updated LibraryOptions :

    • Changed property PathInfos (array)

      Changed items (object):

      • Deleted property NetworkPath (string)

Changed content type : text/json

Updated AddVirtualFolderDto :

  • Changed property LibraryOptions (object)

    Gets or sets library options.

    Updated LibraryOptions :

    • Changed property PathInfos (array)

      Changed items (object):

      • Deleted property NetworkPath (string)

Changed content type : application/*+json

Updated AddVirtualFolderDto :

  • Changed property LibraryOptions (object)

    Gets or sets library options.

    Updated LibraryOptions :

    • Changed property PathInfos (array)

      Changed items (object):

      • Deleted property NetworkPath (string)
POST /Library/VirtualFolders/LibraryOptions
Request:

Changed content type : application/json

Updated UpdateLibraryOptionsDto :

  • Changed property LibraryOptions (object)

    Gets or sets library options.

    Updated LibraryOptions :

    • Changed property PathInfos (array)

      Changed items (object):

      • Deleted property NetworkPath (string)

Changed content type : text/json

Updated UpdateLibraryOptionsDto :

  • Changed property LibraryOptions (object)

    Gets or sets library options.

    Updated LibraryOptions :

    • Changed property PathInfos (array)

      Changed items (object):

      • Deleted property NetworkPath (string)

Changed content type : application/*+json

Updated UpdateLibraryOptionsDto :

  • Changed property LibraryOptions (object)

    Gets or sets library options.

    Updated LibraryOptions :

    • Changed property PathInfos (array)

      Changed items (object):

      • Deleted property NetworkPath (string)

oddstr13
oddstr13 reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression that this was going to stay in for some time still, as quite a few people use the «native» mode in jf4kodi, which depends on this.

There's some discussion after the removal from the UI here #11654

I do not think this is a good idea.

@gnattu
Copy link
Member

gnattu commented Aug 14, 2024 •
edited
Loading

Well it seems like this path is only used for kodi clients and nowhere else, which means we can have some mitigations if we still want to support the native mode:

  • Move the network path to library mapping into a plugin and provide an api endpoint in that plugin, which translate the physical paths on the server mount point to the network path, and let the kodi clients request that api if native mode is preferred.

  • Make this mapping entirely client-side. Users set network path mapping to mount point mapping in the kodi client.

To have this path in the server as part of the library setting is hard to maintain and make it hard to implement proper path handling for both the server and clients other than kodi.

@mcarlton00
Copy link
Member

Well it seems like this path is only used for kodi clients and nowhere else

Kodi native mode, mpv shim, and iirc at least one third party client, but I don't remember which one.

We all hate native mode and it's basically unsupported on the kodi side, but there are unfortunately some circumstances where it does work better (BDMV playback and vobsub subtitles both immediately spring to mind). However, removing it basically just brings it in line with other clients instead of having special oddball treatment.

@PrplHaz4 PrplHaz4 mentioned this pull request Sep 5, 2024
Merged
@nielsvanvelzen nielsvanvelzen requested a review from a team September 6, 2024 19:57
@crobibero crobibero merged commit 675a8a9 into jellyfin:master Sep 7, 2024
12 checks passed
@nielsvanvelzen nielsvanvelzen deleted the remove-network-path branch September 7, 2024 18:40
@oddstr13 oddstr13 mentioned this pull request Oct 1, 2024
Closed
3 tasks
@it5c0z1mG

This comment has been minimized.

Sign in to view
@mcarlton00

This comment has been minimized.

Sign in to view
@it5c0z1mG

This comment has been minimized.

Sign in to view
@omelettedufromagee

This comment was marked as off-topic.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddstr13 oddstr13 oddstr13 left review comments

@Shadowghost Shadowghost Shadowghost approved these changes

@Bond-009 Bond-009 Bond-009 approved these changes

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Jellyfin 10.10
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nielsvanvelzen @gnattu @mcarlton00 @it5c0z1mG @omelettedufromagee @oddstr13 @Shadowghost @Bond-009 @crobibero