Markdown fixes #817
Markdown fixes #817
Conversation
doc test cannot import cursive?
| //! ### Examples | ||
| //! | ||
| //! ```rust | ||
| //! use cursive::utils::markup::markdown::parse; |
There was a problem hiding this comment.
You might need extern crate cursive_core as cursive;, so it really just needs cursive_core, but it looks as cursive for users.
There was a problem hiding this comment.
Thanks - strange though that I cannot reproduce this locally. I'll try.
There was a problem hiding this comment.
You'll need to test with the markdown feature to run these
There was a problem hiding this comment.
Got it, now I can at least reproduce
There was a problem hiding this comment.
Can't seem to fix it... it cannot resolve CursiveExt, and when I remove it, the compiler can't find the run() method.
There was a problem hiding this comment.
CursiveExt is in a different crate, this might just not be possible. If it's ok I remove the example in the doc comment. I put an Markdown example into the examples folder.
There was a problem hiding this comment.
You also don't need to run the cursive app (or even make one), you can focus on parsing the markdown and building the TextView
|
I set the example in the doc comment to "ignore" - let me know if that's ok for you or of course feel free to change. |
This PR contains Markdown usage samples in the documentation and the examples folder as well as some opinionated fixes to the Markdown handling itself:
>for easier soft line breaksThe parsing test has been changed to make it easier to find the failing span; it has also been extended to test the new behaviour.
pulldown-cmarkseems to have a bug that always returns an empty title for links. I updated it to version 0.13 in Cargo.toml, but this unfortunately did not change this.