Skip to content

feat (fcm): Add additional Android Notification Parameters #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 15, 2022
Merged

feat (fcm): Add additional Android Notification Parameters #317

merged 5 commits into from
Mar 15, 2022

Conversation

lahirumaramba
Copy link
Member

@lahirumaramba lahirumaramba commented Mar 4, 2022 •
edited
Loading

Resolves #153

go/admin-fcm-notificaiton-addendum

RELEASE NOTE: Added a series of new parameters to the AndroidNotification class that allow further customization of notifications that target Android devices.

levimatheri and others added 2 commits November 11, 2021 14:10
@levimatheri
Closes #153. Add additional FCM options for Android Notification (#203)
0547948 
* Add additional FCM Android notification options

* Add additional FCM Android notification options
@lahirumaramba
Update API to match the approved changes
32821c0
@lahirumaramba lahirumaramba marked this pull request as ready for review March 4, 2022 19:36
@lahirumaramba lahirumaramba requested a review from chong-shao March 4, 2022 19:37
@lahirumaramba lahirumaramba requested a review from egilmorez March 4, 2022 19:44
This was referenced Mar 4, 2022
Merged
Closed
egilmorez
egilmorez reviewed Mar 4, 2022
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Picked out a few style things to look at, thanks!

chong-shao
chong-shao approved these changes Mar 9, 2022
View reviewed changes
Copy link

@chong-shao chong-shao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Probably we can wait until the naming of visibility and priority to be finalized before submitting this?

@lahirumaramba lahirumaramba requested a review from egilmorez March 14, 2022 19:54
egilmorez
egilmorez approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lahiru!

@lahirumaramba lahirumaramba merged commit 2f7c9a9 into master Mar 15, 2022
@lahirumaramba lahirumaramba deleted the lm-fcm-notif branch March 15, 2022 18:08
@lahirumaramba lahirumaramba mentioned this pull request Mar 23, 2022
Merged
lahirumaramba added a commit that referenced this pull request Mar 24, 2022
@lahirumaramba
[chore] Release 2.3.0 (#319)
0f5b388 
Includes #317 and #203
@lahirumaramba lahirumaramba mentioned this pull request Mar 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egilmorez egilmorez egilmorez approved these changes

@chong-shao chong-shao chong-shao approved these changes

Assignees

@egilmorez egilmorez

Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add latest HTTP v1 options
4 participants
@lahirumaramba @egilmorez @chong-shao @levimatheri