Skip to content

Implemented clock_gettime_nsec_np in libraries for Apple Silicon support #43343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2020

Conversation

snickler
Copy link
Contributor

Replaced mach_absolute_time with clock_gettime_nsec_np.
Replaced HAVE_MACH_ABSOLUTE_TIME directive with HAVE_CLOCK_GETTIME_NSEC_NP.

Fixes #43320

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@snickler
Copy link
Contributor Author

A big thanks to @vcsjones for some well needed explanations and help! ^_^

@snickler
Copy link
Contributor Author

Hm. @jkotas how do we make these tests run again? It seems that a few of them timed out.

@jkotas
Copy link
Member

jkotas commented Oct 14, 2020

All failures look like infrastructure issues. I have restarted the tests just to be sure.

@jkotas jkotas merged commit d67cc2c into dotnet:master Oct 14, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change libraries to use clock_gettime_nsec_np instead of mach_absolute_time
3 participants