Skip to content

Implement external access control based on previous PR #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2021
Merged

Implement external access control based on previous PR #638

merged 2 commits into from
Jan 20, 2021

Conversation

danfickle
Copy link
Owner

#528 #509 @syjer @vader

Based on #528 so we can implement #509.

Comments welcome.

Needs a couple more tests.

@syjer
Copy link
Contributor

syjer commented Jan 19, 2021

hi @danfickle , thank you for taking over the two PR. I didn't had enough time/focus for completing them...

Looking at the code I think all the use cases are covered.

@danfickle danfickle marked this pull request as ready for review January 20, 2021 06:32
@danfickle danfickle merged commit d20825b into open-dev-v1 Jan 20, 2021
@danfickle danfickle deleted the external_resource_access_control branch January 20, 2021 06:48
@danfickle danfickle mentioned this pull request Mar 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danfickle @syjer