Skip to content

fix(Core/Player): Mutilate + Cold Blood crit fix #22308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(Core/Player): Mutilate + Cold Blood crit fix #22308

wants to merge 2 commits into from
+15 −0

Conversation

Hyjarion
Copy link
Contributor

@Hyjarion Hyjarion commented Jun 12, 2025 •
edited
Loading

Mutilate was only critting with main-hand while Cold Blood

Closes AzerothCore issue #20027

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.
  1. Create a Rogue
  2. Learn and use Mutilate with Cold Blood
  3. See the double crit
  4. Smile :)

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@Hyjarion
fix(Core/Player): Mutilate + Cold Blood crit fix
2bf6b82 
Mutilate was only critting with main-hand while Cold Blood

Closes AzerothCore issue azerothcore#20027
@github-actions github-actions bot added CORE Related to the core file-cpp Used to trigger the matrix build labels Jun 12, 2025
@Nyeriah
Copy link
Member

Nyeriah commented Jun 12, 2025

What happens if the main hand attack hits but the offhand attack misses? Is the aura removed?

@Hyjarion
Copy link
Contributor Author

What happens if the main hand attack hits but the offhand attack misses? Is the aura removed?

There's no such thing because if the main Mutilate spell (1329) fails then neither the main nor the off hand attack will be executed.

@Nyeriah
Copy link
Member

Nyeriah commented Jun 12, 2025

The off-hand attack hit chance is rolled independently and may miss. My question was, if the main spell or main hand attack crits and the offhand attack misses, will the aura be removed?

@Nyeriah Nyeriah requested a review from sogladev June 12, 2025 19:40
@Hyjarion
Copy link
Contributor Author

The off-hand attack hit chance is rolled independently and may miss. My question was, if the main spell or main hand attack crits and the offhand attack misses, will the aura be removed?

It may not miss. If Mutilate (1329) was not missed then main-hand Mutilate (5374) and off-hand Mutilate (27576) will hit no matter what they cannot be missed. That is blizzlike.

@Nyeriah
Copy link
Member

Nyeriah commented Jun 12, 2025 •
edited
Loading

Sorry about that, I am discussing it with people and getting information from them

By "missing" they meant that the second hit may not go off (for example if the first hit kills the creature), see the image below of tests conducted with the previous PR that tried addressing this issue

image

So my question is, was this scenario accounted for?

@Hyjarion
Copy link
Contributor Author

Ahhh I understand. Gonna look into that.

@github-actions github-actions bot added DB related to the SQL database Script labels Jun 12, 2025
@Hyjarion
Copy link
Contributor Author

Hyjarion commented Jun 12, 2025 •
edited
Loading

Done. :) EDIT: no not done, it will now remove on Miss too, hold on.

@Hyjarion Hyjarion force-pushed the fix-issue-mutilate branch from 0326df5 to 2bf6b82 Compare June 13, 2025 00:02
@github-actions github-actions bot removed DB related to the SQL database Script labels Jun 13, 2025
@Hyjarion
Copy link
Contributor Author

Okay test it out guys please, should work fine now.

@Hyjarion
Copy link
Contributor Author

Bump @Nyeriah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sogladev sogladev Awaiting requested review from sogladev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CORE Related to the core file-cpp Used to trigger the matrix build Ready to be Reviewed Waiting to be Tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💰50$ Bounty - Cold Blood & Mutilate
3 participants
@Hyjarion @Nyeriah @TheSCREWEDSoftware