[MINOR] Fixed some of the maven warnings #3310
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was not sure if we need to include the LICENSE of dependencies in shaded jar. If yes, i will revert the LICENSE exclusion. |
s0nskar
changed the title
s0nskar
changed the title
the LICENSE/NOTICE files should exactly match the artifacts' content, since shaded jar contains the deps classes, LICENSE/NOTICE files should also reflect that. |
|
This surely improves our code smell and reminds me of a joke about developers.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixed maven warnings that show up while building the celeborn project
Why are the changes needed?
NA
Does this PR introduce any user-facing change?
NA
How was this patch tested?
Existing project workflows