Support Windows Build #159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePedroo
reviewed
May 13, 2025
| @@ -34,7 +34,7 @@ val CStandardFlags = arrayOf( | |||
| "-DMIN_KSU_VERSION=$minKsuVersion", | |||
| "-DMAX_KSU_VERSION=$maxKsuVersion", | |||
| "-DMIN_MAGISK_VERSION=$minMagiskVersion", | |||
| "-DZKSU_VERSION=\"$verName\"" | |||
| "-DZKSU_VERSION=\\\"$verName\\\"" | |||
There was a problem hiding this comment.
Perhaps due to differences in platform command-line tools, on Windows, ZKSU_VERSION becomes
#define ZKSU_VERSION 1.0.0instead of
#define ZKSU_VERSION "1.0.0".
ThePedroo
added
confirmed
|
The additional " for ZKSU_VERSION makes Linux builds fail though. |
ThePedroo
force-pushed
the
main
branch
5 times, most recently
from
453a71c to
ed347e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit adds support for building the ReZygisk project on Windows platforms.
Why
Previously, building ReZygisk was primarily supported on Unix-like systems. By adding Windows build support, we enable developers who use Windows environments to compile and contribute to the project more easily. This change enhances cross-platform compatibility and broadens the contributor base.
Checkmarks
Additional information
If you have any additional information, write it here