-
-
Notifications
You must be signed in to change notification settings - Fork 3k
[Content.Pipeline] Add new content project system #8830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
private static Stream PlatformOpenStream(string safeName) | ||
{ | ||
return Android.App.Application.Context.Assets.Open(safeName); | ||
var cachePath = Path.Combine(CacheLocation, safeName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be a potential vector for hacking game content at runtime? Should there be a way to ship a game without this feature turned on? I'm pretty sure allot of people wouldn't want this in a release build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold your horses for the PR description, will talk about it in there 😄
So how do we keep the old pipeline "builder" and the new one from getting mixed up while we're supporting both? Seems like we have |
using System.IO; | ||
using System.Net.Http; | ||
using System.Net.Sockets; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not all console platforms have working networking at the C# level.
We need to put any networking into platform calls. The default implementation for PC/mobile is free to use C# networking APIs. For console it is a different story.
PlatformInit(); | ||
ModifiedTimes = LoadModifiedTimes(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like above... all the network stuff needs to be a platform specific implementation.
|
||
private static Dictionary<string, long> ModifiedTimes { get; set; } | ||
|
||
private static HttpClient Client { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering about the impact of referencing HttpClient
, it makes self-contained apps substantially bigger and untrimmable.
WIP