Skip to content

Remove the RestoreContentCompiler as it was redundant. #8815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

dellis1972
Copy link
Contributor

@dellis1972 dellis1972 commented Jun 3, 2025

  • Remove the code which installed tools in a custom folder.
  • Added a new _RestoreMGCBTool target. This target will restore the tools, but importantly it will put a flag in the obj directory to track that is has done so. This means that the target will not run on every build.
  • Moved the content build from before Build to before Compile but after ResolveProjectReferences , this allows any dependencies to be built first. So if you reference a content pipeline extension it will be built before the content is built.

@dellis1972 dellis1972 force-pushed the dev/dellis1972/msbuildchanges branch 2 times, most recently from 2f2f4ce to 9ea3987 Compare June 7, 2025 15:28
@SimonDarksideJ
Copy link
Contributor

Tested and working good @dellis1972 , will need migration docs updating to remove the <Target Name="RestoreDotnetTools" section from existing projects and the templates updating.
But it's good, even in an upgrade scenario, it will update the tools to match the nuget dependency

@dellis1972
Copy link
Contributor Author

@SimonDarksideJ where are we with testing on this ? I can't remember?

@SimonDarksideJ
Copy link
Contributor

The last change broke some things I found, it made it harder to both upgrade and use.

  1. Create a project with the 3.8.4 templates
  2. Build and then clean to ensure everything works
  3. Manually edit the dotnet tools and csproj to use new local configured nugets
  4. Edit csproj to remove restore action
  5. Use VS or DotNet restore to update packages
  6. Try and build
  7. See restore / tools issues, also Android refuses to build content in a combined build using startkit template. (even though running command manually or using mgcb works)

I got numerous issues getting projects to build or even upgrade with the latest builds. The previous build seemed to work better.

@dellis1972 dellis1972 force-pushed the dev/dellis1972/msbuildchanges branch from 9ea3987 to 2e6514e Compare June 17, 2025 10:22
@dellis1972
Copy link
Contributor Author

  1. See restore / tools issues, also Android refuses to build content in a combined build using startkit template. (even though running command manually or using mgcb works)

I got numerous issues getting projects to build or even upgrade with the latest builds. The previous build seemed to work better.

Do you have the actual error messages you get?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants