More Text Input Support (#8672) Recommit
#8740
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SimonDarksideJ This is recommit PR for |
|
Can you please check your commits @Cn-mjt44 , we do not accept PR's with Formatting changes unless the file in question is actually being modified. For instance, BoundingBox has no actual changes other than formatting. Please only commit files that have actually been altered. Additionally, this fails the "Console Check" which validates AoT compatibility required for console support and the Native pipeline, features such as reflection are not permitted. |
|
@SimonDarksideJ I have push this in force mode, and it don't have any formatting changes. |
|
Gah, conflicts @Cn-mjt44 , can you update from develop and resolve so we can get this merged please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Event handling.
Fixes #
The text input now trigger by
WM_CHARandWM_UNICHARDescription of Change
IsInputingText,IMEPositionandClipboardTexttoabstract class GameWindowWM_CHARorWM_UNICHARSDL_TEXTINPUTWM_IME_COMPOSITIONorWM_IME_ENDCOMPOSITIONSDL_TEXTEDITING