Make new_window asynchronous #4297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
added
bug
jkelleyrtp
approved these changes
Jun 19, 2025
It is pretty common to call warning: unused implementer of `futures_util::Future` that must be used
--> examples/popup.rs:24:9
|
24 | / ... dioxus::desktop::window().new_window(
25 | | ... VirtualDom::new_with_props(popup, Rc::new(move |s| ...
26 | | ... Default::default(),
27 | | ... );
| |_______^
|
= note: futures do nothing unless you `.await` or poll them
= note: `#[warn(unused_must_use)]` on by default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows, the main webview thread handles both the IPC handler and creating the webview. We handle events inside of the IPC handler synchronously. Windows prevents the main thread from becoming re-entrant when we try to create a new window synchronously inside of that same thread. Instead we can queue the new window creation for the next time the event loop is called after the IPC handler is done.
This PR is a very similar approach to #3668 with a bit more documentation about why the method needs to be asynchronous.
Closes #3080
Relevant documentation/issues: