Use different release profiles for desktop and server builds, adhoc profiles #3693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was chatting with the bevy folks about #4168 and they pointed me to some code that lets you create adhoc profiles. They do it here: https://github.com/TheBevyFlock/bevy_cli/blob/main/src%2Fweb%2Fprofiles.rs Since this PR has sat here so long and I've neglected to merge it, I'll adjust it so it doesn't generate profiles anymore, but instead just uses the adhoc profile approach. Sorry for refusing to merge it, but I guess it worked out since we found a better solution. It's worth noting that we should document these profiles. |
jkelleyrtp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In release builds, both desktop and server builds were using the same target and profile so they output their binary to the same location. This was causing either the server or the client to be used for both bundles. This PR fixes the issue by introducing release variants of the desktop and server profiles. Now when the server and desktop targets are built they output to a separate profile folder inside of
/targetFixes #3689
Fixes #3600
Fixes #3573
Fixes #3884
Fixes #4168