Skip to content

Move Slurm H4D Blueprint and remove firewall rules for IRDMA VPCs #4240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

abbas1902
Copy link
Collaborator

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@abbas1902 abbas1902 marked this pull request as ready for review June 3, 2025 23:58
@abbas1902 abbas1902 requested review from samskillman and a team as code owners June 3, 2025 23:58
@abbas1902 abbas1902 added the release-breaking-changes Prevents "smooth" re-deploy across versions label Jun 3, 2025
@mr0re1
Copy link
Collaborator

mr0re1 commented Jun 4, 2025

I don't think it merits to have a "breaking change" badge, since it only affects blueprints.

@abbas1902
Copy link
Collaborator Author

abbas1902 commented Jun 4, 2025

I don't think it merits to have a "breaking change" badge, since it only affects blueprints.

Agreed, my logic for having it is more of a warning that "hey if you have older versions of this blueprint (or blueprints based on this) they will cease functioning unless you remove this". Probably goes without saying but not sure how else to convey this message, maybe I can just add a generic node on the release notes about it.

@abbas1902 abbas1902 added release-chore To not include into release notes and removed release-breaking-changes Prevents "smooth" re-deploy across versions labels Jun 4, 2025
@abbas1902 abbas1902 merged commit 6dc1227 into GoogleCloudPlatform:develop Jun 5, 2025
14 of 67 checks passed
@abbas1902 abbas1902 deleted the fwless branch June 5, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants