The Wayback Machine - https://web.archive.org/web/20201127131338/https://github.com/getsentry/raven-python/pull/977
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer provide form data for Flask. Fixes #457 #977

Open
wants to merge 1 commit into
base: master
from

Conversation

@mitsuhiko
Copy link
Member

@mitsuhiko mitsuhiko commented Mar 2, 2017

I think this feature does not make much sense, particularly because we badly
trim down the form data on the server anyways for security and size reasons.

@dcramer
dcramer approved these changes Mar 2, 2017
Copy link
Member

@dcramer dcramer left a comment

im assuming it isnt possible to say "is this streaming" to decide if we could opportunistically capture it?

@mitsuhiko
Copy link
Member Author

@mitsuhiko mitsuhiko commented Mar 2, 2017

@dcramer there are some ways to do it but it is not a stable API in Flask. Ideally we could access the cache value in case it has been pulled in before.

@mitsuhiko
Copy link
Member Author

@mitsuhiko mitsuhiko commented Mar 2, 2017

Makes we wonder what we do in Django. That should in theory have the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.