The Wayback Machine - https://web.archive.org/web/20201127135635/https://github.com/getsentry/raven-python/pull/1309
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow `extra` to be None in breadcrumbs processing #1309

Open
wants to merge 1 commit into
base: master
from

Conversation

@joker-official
Copy link

@joker-official joker-official commented Nov 2, 2018

Sometimes, extra is passed in as a default parameter of another
function and can therefore be None. This fixes:

Traceback (most recent call last):
  File "raven/breadcrumbs.py", line 77, in get_buffer
	processor(payload)
  File "raven/breadcrumbs.py", line 143, in processor
	data_value.update(extra)
TypeError: 'NoneType' object is not iterable
Sometimes, `extra` is passed in as a default parameter of another
function and can therefore be `None`. This fixes:

	Traceback (most recent call last):
	  File "raven/breadcrumbs.py", line 77, in get_buffer
		processor(payload)
	  File "raven/breadcrumbs.py", line 143, in processor
		data_value.update(extra)
	TypeError: 'NoneType' object is not iterable
@david-volantio
Copy link

@david-volantio david-volantio commented Jun 11, 2020

The issue addressed by this PR is preventing my team from upgrading to 6.10.0. The issue in my particular project arises when calling captureMessage (that I know of - I haven't exhaustively testing every call in my project) without extra, so I'm not sure where extra is being defaulted to None but it would seem to be between captureMessage and breadcrumb processing.

@ashwoods
Copy link
Contributor

@ashwoods ashwoods commented Jun 11, 2020

@david-volantio if you are able to upgrade, any reason for not being able to give the new sdk a go? https://github.com/getsentry/sentry-python

@david-volantio
Copy link

@david-volantio david-volantio commented Jun 12, 2020

@ashwoods a fair point - I was just hoping we could move to the latest release but updating to sentry-python is definitely on our roadmap. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.