Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
[WIP] update celery context #1186
Conversation
@ryan-s Mind adding a small test? :) I forgot starting the comment with a thank you. |
@ryan-s It's hard to see from the logs (a problem with xdist maybe), but this is still failing three tests:
|
@ashwoods Ill be circling back to this next week. Getting the client to update the context in the logging with the mocks has been problematic. It's also becoming clear that Im conflating the logger and the celery handlers concepts, so I'm going to look to see if there is a more elegant way to handle this. |
@ryan-s thx, let me know if there is anything I can do to help. |
The current implementation of the celery client prevents the ability to pass context on a per process basis. We have found that being able to tag and filter based on the arguments or key word arguments is immensely helpful in tracking down where failures are in the system.