The Wayback Machine - https://web.archive.org/web/20201121003857/https://github.com/github/gh-ost/pull/684
Skip to content

/ gh-ost

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed DECIMAL datatype #684

Merged
merged 9 commits into from Jan 13, 2019
Merged

Fixed DECIMAL datatype #684

merged 9 commits into from Jan 13, 2019

Conversation

@shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Nov 28, 2018

Testing #681

Initial commit confirms the bug reported in #681
Shlomi Noach added 2 commits Nov 28, 2018
Shlomi Noach
Testing DECIMAL datatype
Loading status checks…
00f5044
Shlomi Noach
Merge branch 'master' into test-decimal
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6f673fa
@shlomi-noach shlomi-noach mentioned this pull request Nov 28, 2018
Closed
Shlomi Noach added 5 commits Jan 1, 2019
Shlomi Noach
Merge branch 'master' into test-decimal
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ffd8fa0
Shlomi Noach
Updated go-mysql library, now with fix to decimal. May break datetime
2553149
Shlomi Noach
updated go-mysql
Loading status checks…
14e396e
Shlomi Noach
applying datetime patch
Loading status checks…
f25d0b1
Shlomi Noach
trying something...
Loading status checks…
0be91ba
@shlomi-noach
Copy link
Contributor Author

@shlomi-noach shlomi-noach commented Jan 1, 2019

@Tomas2046 please explain your comments to prove you're not a bot.
Shlomi Noach
reverting some changes
Loading status checks…
7c17cee
@shlomi-noach shlomi-noach temporarily deployed to production/mysql_role=ghost_testing Jan 1, 2019 Inactive
Shlomi Noach
old timestamp, old datetime
Loading status checks…
7e0bdbe
@shlomi-noach
Copy link
Contributor Author

@shlomi-noach shlomi-noach commented Jan 1, 2019

Updated underlying go-mysql library to get the fixes in siddontang/go-mysql#332.

However, had to re-apply TIMESTAMP and DATETIME patches; go-mysql uses a new mechanism for parsing both old and new TIMESTAMP and DATETIME which seem to break gh-ost's tests whenever a non-UTC timezone is involved. I haven't been successful in finding out exactly why this happens, and so I've re-applied old temporal logic on top of the new changes.
@shlomi-noach shlomi-noach changed the title Testing DECIMAL datatype Fixed DECIMAL datatype Jan 2, 2019
@kwburgess kwburgess mentioned this pull request Jan 2, 2019
Open
@shlomi-noach shlomi-noach mentioned this pull request Jan 7, 2019
Closed
@shlomi-noach
Copy link
Contributor Author

@shlomi-noach shlomi-noach commented Jan 13, 2019

tested in prod, looking good.
@shlomi-noach shlomi-noach merged commit d5c374a into master Jan 13, 2019
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
gh-ost-build-deploy-tarball Build #14090042 succeeded in 7s
Details
gh-ost-replica-tests Build #14090043 succeeded in 1002s
Details
@shlomi-noach shlomi-noach deleted the test-decimal branch Jan 13, 2019
@shlomi-noach
Copy link
Contributor Author

@shlomi-noach shlomi-noach commented Jan 13, 2019

I'll release this/next week
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@shlomi-noach
You can’t perform that action at this time.