New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix push image #1355

Merged
merged 1 commit into from Oct 30, 2015

Conversation

Projects
None yet
4 participants
@jimmyxian
Contributor

jimmyxian commented Oct 29, 2015

Fix: #1354

tag in push url is a Query Parameter

Signed-off-by: Xian Chaobo [email protected]

fix push image
Signed-off-by: Xian Chaobo <[email protected]>
@jimmyxian

This comment has been minimized.

Show comment
Hide comment
@jimmyxian

jimmyxian Oct 29, 2015

Contributor

ping @linecheng
Try this and see if it works. Thanks

Contributor

jimmyxian commented Oct 29, 2015

ping @linecheng
Try this and see if it works. Thanks

@jimmyxian

This comment has been minimized.

Show comment
Hide comment
@jimmyxian

jimmyxian Oct 29, 2015

Contributor

ping @vieux @abronan
The integration test for Push need a registry. Maybe we can add later.

Contributor

jimmyxian commented Oct 29, 2015

ping @vieux @abronan
The integration test for Push need a registry. Maybe we can add later.

@chengjingtao

This comment has been minimized.

Show comment
Hide comment
@chengjingtao

chengjingtao Oct 30, 2015

ping @jimmyxian
I have already test it and it works very well.
Thanks for your job .

chengjingtao commented Oct 30, 2015

ping @jimmyxian
I have already test it and it works very well.
Thanks for your job .

@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Oct 30, 2015

Contributor

LGTM

Contributor

vieux commented Oct 30, 2015

LGTM

vieux added a commit that referenced this pull request Oct 30, 2015

@vieux vieux merged commit 0a8cf2c into docker:master Oct 30, 2015

2 of 3 checks passed

janky Jenkins build Swarm-PRs 1245 has failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
docker/dco-signed All commits signed
Details

ChristianKniep pushed a commit to ChristianKniep/swarm that referenced this pull request Jul 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment