New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with timeouts in mesos #1330

Merged
merged 1 commit into from Oct 23, 2015

Conversation

Projects
None yet
4 participants
@vieux
Contributor

vieux commented Oct 23, 2015

Fix #1183

This PR fixes a race, unfortunately I cannot reproduce it with our current CI (docker in docker means it's localhost, so super fast)

But I was able to confirm this fixes some issues, I believe it's going to fix #1183

fix issue with timeouts in mesos
Signed-off-by: Victor Vieux <[email protected]>
@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux
Contributor

vieux commented Oct 23, 2015

@jimenez

This comment has been minimized.

Show comment
Hide comment
@jimenez

jimenez Oct 23, 2015

Contributor

LGTM for now, we should merge this to have a quick fix but start thinking on a more maintainable refactor

Contributor

jimenez commented Oct 23, 2015

LGTM for now, we should merge this to have a quick fix but start thinking on a more maintainable refactor

abronan added a commit that referenced this pull request Oct 23, 2015

@abronan abronan merged commit a7a82bd into docker:master Oct 23, 2015

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
docker/dco-signed All commits signed
Details
janky Jenkins build Swarm-PRs 1189 has succeeded
Details

@vieux vieux deleted the vieux:fix_mesos_timeout_issue branch Oct 23, 2015

ChristianKniep pushed a commit to ChristianKniep/swarm that referenced this pull request Jul 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment