Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfix issue with timeouts in mesos #1330
Conversation
vieux
added
status/2-code-review
priority/P0
area/mesos
labels
Oct 23, 2015
vieux
self-assigned this
Oct 23, 2015
vieux
added this to the 1.0.0 milestone
Oct 23, 2015
GordonTheTurtle
added
the
status/0-triage
label
Oct 23, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jimenez
Oct 23, 2015
Contributor
LGTM for now, we should merge this to have a quick fix but start thinking on a more maintainable refactor
LGTM for now, we should merge this to have a quick fix but start thinking on a more maintainable refactor |
vieux commentedOct 23, 2015
Fix #1183
This PR fixes a race, unfortunately I cannot reproduce it with our current CI (docker in docker means it's localhost, so super fast)
But I was able to confirm this fixes some issues, I believe it's going to fix #1183