New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing problems with the instructions #1817

Merged
merged 1 commit into from Feb 27, 2016

Conversation

Projects
None yet
4 participants
@moxiegirl

moxiegirl commented Feb 14, 2016

Updating the application after test
Removing the sudo as it caused issues
Adding new screen shots
Breaking into several files/sections

Signed-off-by: Mary Anthony [email protected]

@moxiegirl

This comment has been minimized.

Show comment
Hide comment
@moxiegirl

moxiegirl Feb 14, 2016

@dongluochen You have your break out sir. @nigelpoulton please see this update we broke it into files. The sudo addition as a bad suggestion on my part --- sudo ignores environment settings (thanks @nicolaka for the info it unstuck me) and @mgoelzer also for the check on the setup.

moxiegirl commented Feb 14, 2016

@dongluochen You have your break out sir. @nigelpoulton please see this update we broke it into files. The sudo addition as a bad suggestion on my part --- sudo ignores environment settings (thanks @nicolaka for the info it unstuck me) and @mgoelzer also for the check on the setup.

@moxiegirl

This comment has been minimized.

Show comment
Hide comment
@moxiegirl

moxiegirl Feb 26, 2016

@dongluochen @mgoelzer Please do a final check and LGTM here. I'd like to merge this and make it live today.

moxiegirl commented Feb 26, 2016

@dongluochen @mgoelzer Please do a final check and LGTM here. I'd like to merge this and make it live today.

@dongluochen

This comment has been minimized.

Show comment
Hide comment
@dongluochen

dongluochen Feb 27, 2016

Contributor

@moxiegirl There is a request #1899 to upgrade Interlock to 1.0.0. I think It can be done in separate PR.

Contributor

dongluochen commented Feb 27, 2016

@moxiegirl There is a request #1899 to upgrade Interlock to 1.0.0. I think It can be done in separate PR.

Mary Anthony
Fixing problems with the instructions
Updating the application after test
Removing the sudo as it caused issues
Adding new screen shots
Breaking into several files/sections
Adding in the alias from the old single page version
Moving to old path to avoid an alias
Adding in Dong's comments
Updating with latest fixes
Fixing nits and more

Signed-off-by: Mary Anthony <[email protected]>
@moxiegirl

This comment has been minimized.

Show comment
Hide comment
@moxiegirl

moxiegirl Feb 27, 2016

@vieux @dongluochen merging per our conversation yesterday

moxiegirl commented Feb 27, 2016

@vieux @dongluochen merging per our conversation yesterday

moxiegirl pushed a commit that referenced this pull request Feb 27, 2016

moxiegirl
Merge pull request #1817 from moxiegirl/test-swarm-at-scale
Fixing problems with the instructions

@moxiegirl moxiegirl merged commit b43a2c2 into docker:master Feb 27, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
docker/dco-signed All commits signed
Details
documentation success 2 tests run, 0 skipped, 0 failed.
Details

ChristianKniep pushed a commit to ChristianKniep/swarm that referenced this pull request Jul 27, 2017

moxiegirl
Merge pull request #1817 from moxiegirl/test-swarm-at-scale
Fixing problems with the instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment