The Wayback Machine - https://web.archive.org/web/20210116044954/https://github.com/square/moshi/pull/360
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow delegates for intermediates in adapters. #360

Merged
merged 1 commit into from Oct 5, 2017

Conversation

@NightlyNexus
Copy link
Collaborator

@NightlyNexus NightlyNexus commented Oct 4, 2017

Closes #346.
Builds on #272.

I don't have a real use case for this, but it could be surprising that some delegation works and some doesn't.

@NightlyNexus NightlyNexus force-pushed the eric.20171004.delegate-adapters branch from c068e55 to de336ef Oct 4, 2017
@@ -130,6 +132,36 @@
assertThat(adapter.fromJson("[{\"x\":5,\"y\":8}]")).isEqualTo(point);
}

@Test public void toAndFromWithIntermediate() throws Exception {

This comment has been minimized.

@swankjesse
Copy link
Member

@swankjesse swankjesse commented Oct 5, 2017

I love it.

@swankjesse swankjesse merged commit 8bf298a into master Oct 5, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@NightlyNexus NightlyNexus deleted the eric.20171004.delegate-adapters branch Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.