The Wayback Machine - https://web.archive.org/web/20210116045536/https://github.com/square/moshi/pull/259
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error-prone compiler. #259

Merged
merged 4 commits into from Feb 15, 2017
Merged

Add error-prone compiler. #259

merged 4 commits into from Feb 15, 2017

Conversation

@JakeWharton
Copy link
Member

@JakeWharton JakeWharton commented Feb 14, 2017

No description provided.

@JakeWharton JakeWharton force-pushed the jw/2017-02-13/error-prone branch from f47cba3 to b071487 Feb 14, 2017
@JakeWharton JakeWharton force-pushed the jw/2017-02-13/error-prone branch from b071487 to 5adce61 Feb 15, 2017
@JakeWharton JakeWharton force-pushed the jw/2017-02-13/error-prone branch from 5adce61 to 56bdbe0 Feb 15, 2017
Copy link
Collaborator

@NightlyNexus NightlyNexus left a comment

lgtm. Works for me locally.

<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-compiler-javac-errorprone</artifactId>
<version>2.8</version>

This comment has been minimized.

@NightlyNexus

NightlyNexus Feb 15, 2017
Collaborator

2.8.1?

@@ -80,11 +80,25 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.0</version>
<version>3.3</version>

This comment has been minimized.

@NightlyNexus

NightlyNexus Feb 15, 2017
Collaborator

3.6.1?

@swankjesse swankjesse merged commit 05b0a46 into master Feb 15, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
swankjesse added a commit that referenced this pull request Apr 16, 2017
* Fix error-prone warning

* Add error-prone compiler.

* Suppress warning about calling getClass() on annotation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.