Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport asterisks in image reference filter #2751
Conversation
GordonTheTurtle
added
the
dco/no
label
Jun 28, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
GordonTheTurtle
Jun 28, 2017
Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "support_regex_filter" [email protected]:wsong/swarm.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one.
GordonTheTurtle
commented
Jun 28, 2017
|
Please sign your commits following these rules: $ git clone -b "support_regex_filter" [email protected]:wsong/swarm.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
GordonTheTurtle
removed
the
dco/no
label
Jun 28, 2017
nishanttotla
added
area/API
area/image
labels
Jun 29, 2017
nishanttotla
added this to the 1.3.0 milestone
Jun 29, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nishanttotla
Jun 29, 2017
Contributor
Let's take this PR in for the next release (not the upcoming one). This will need to be rebased once for the updated API.
One thing that concerns me here is that here's a lot of old code (pre github.comdocker/distribution) that directly handles image strings. I want to be extra careful that mixing that and the distribution package will not cause problems.
|
Let's take this PR in for the next release (not the upcoming one). This will need to be rebased once for the updated API. One thing that concerns me here is that here's a lot of old code (pre |
nishanttotla
modified the milestones:
1.2.8,
1.3.0
Jul 10, 2017
nishanttotla
approved these changes
Jul 10, 2017
LGTM
I restarted the CI, let's wait for that before merging.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@wsong can you check if the test failures are related? |
nishanttotla
modified the milestones:
1.3.0,
1.2.8
Jul 10, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Test failures all appear unrelated |
wsong commentedJun 28, 2017
No description provided.