Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUse map to optimize Entries.Diff() #2556
Conversation
GordonTheTurtle
added
the
dco/no
label
Nov 29, 2016
GordonTheTurtle
removed
the
dco/no
label
Nov 29, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dongluochen
Nov 29, 2016
Contributor
@skoo87 vendor/github.com/docker/docker/pkg/discovery/entry.go is vendored from github.com/docker/docker/pkg/discovery/entry.go in docker project. If you want to make this change, you should open a PR in docker/docker to update entry.go. Then vendor it to Swarm.
|
@skoo87 |
dongluochen
added
the
area/discovery
label
Nov 29, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
skoo87
commented
Nov 30, 2016
|
@dongluochen Oh, Ok, I will close the PR. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
GordonTheTurtle
Nov 30, 2016
Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "improve-diff" [email protected]:skoo87/swarm.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354164816
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one.
GordonTheTurtle
commented
Nov 30, 2016
|
Please sign your commits following these rules: $ git clone -b "improve-diff" [email protected]:skoo87/swarm.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354164816
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
GordonTheTurtle
added
the
dco/no
label
Nov 30, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Any update with this ? @skoo87 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nishanttotla
Jul 18, 2017
Contributor
@skoo87 can you please rebase the PR and look at the comments above.
|
@skoo87 can you please rebase the PR and look at the comments above. |
skoo87 commentedNov 29, 2016
The Entries.Diff() cost a lot of CPU resource when a lot of Docker nodes. So use map to optimize it, may be used more memory space, but time is shortened.