Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: johnno1962/InjectionIII
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: johnno1962/InjectionIII
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: auto-select-project
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Jun 21, 2018

  1. Injection iii zlli fork (#28) 

    * fix “get wrong connection project” problem

I found a “get wrong connection project” problem,causes the injection function to be unavailable.

see this log:
“2018-06-19 18:27:23.907189+0800 InjectionIII[61600:2282765] Connection with project file: /Users/zhaolei/Documents/demo/InjectionIII/InjectionIII.xcodeproj”

The reason for the problem : xcode.activeWorkspaceDocument is related to the project opening order，when I open a testProject before  open InjectionIIIProject.And run both xcode(try to connect),xcode.activeWorkspaceDocument point to InjectionIIIProject(can see the above log)

I fixed this problem and have tested it: get connecting project Name from frameworkPath (client write to server), and traverse all workspaceDocuments to find out which project is connecting.

I has 6 years of iOS development experience,but this is my first Github Pull Request.I will be glad that this request can be passed.
And this project is really owesome!

* add logic: "fall-back to the activeWorkspaceDocument.file.path if it doesn’t find a workspace with the binary's name."

1. add function method "findConnectingProject" ,package related logic.
2. add logic: "fall-back to the activeWorkspaceDocument.file.path if it doesn’t find a workspace with the binary's name."
    @zlit @johnno1962
    zlit authored and johnno1962 committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    315d655 View commit details
    Browse the repository at this point in the history
Loading