Skip to content

Commit e68d100

Browse files
authored
change unifiedWorkerHarnessContainerImage to test arg from experiment (GoogleCloudPlatform#2100)
Signed-off-by: Jeffrey Kinard <[email protected]>
1 parent 8ad9a7b commit e68d100

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

.github/workflows/uw-tests.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,9 @@ jobs:
3333
HARNESS_IMAGE: ${{ inputs.unifiedWorkerHarnessContainerImage }}
3434
- name: Checkout code
3535
uses: actions/checkout@1e31de5234b9f8995739874a8ce0492dc87873e2 # v4.0.0
36-
with:
37-
fetch-depth: 0
38-
ref: ${{ steps.variables.outputs.releaseTag }}
39-
# token: ${{ secrets.RELEASE_TOKEN }}
36+
# with:
37+
# fetch-depth: 0
38+
# ref: ${{ steps.variables.outputs.releaseTag }}
4039
- name: Setup Environment
4140
id: setup-env
4241
uses: ./.github/actions/setup-env

it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/TemplateTestBase.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -499,13 +499,11 @@ protected LaunchInfo launchTemplate(
499499
options.addParameter("sdkContainerImage", System.getProperty("sdkContainerImage"));
500500
}
501501
if (unifiedWorkerHarnessContainerImage != null) {
502-
appendExperiment(
503-
options,
504-
"runner_harness_container_image="
505-
+ System.getProperty("unifiedWorkerHarnessContainerImage"));
502+
options.addParameter(
503+
"runner_harness_container_image",
504+
System.getProperty("unifiedWorkerHarnessContainerImage"));
506505
}
507-
if (System.getProperty("uwStagingExperiments") != null
508-
|| unifiedWorkerHarnessContainerImage != null) {
506+
if (System.getProperty("uwStagingExperiments") != null) {
509507
appendExperiment(options, "disable_worker_rolling_upgrade");
510508
appendExperiment(options, "use_beam_bq_sink");
511509
appendExperiment(options, "beam_fn_api");

0 commit comments

Comments
 (0)