Fix Spanner Load tests and add display test report (GoogleCloudPlatform#2092)

darshan-sj · web-flow · commit 5b0c2cdb0b04 · 2024-12-31T18:44:46.000+05:30
* correcting lt failures

* Adding test report
diff --git a/.github/workflows/spanner-load-tests.yml b/.github/workflows/spanner-load-tests.yml
@@ -67,7 +67,16 @@ jobs:
       with:
         name: surefire-test-results
         path: '**/surefire-reports/TEST-*.xml'
-        retention-days: 1
+        retention-days: 30
+    - name: Load Test report on GitHub
+      uses: dorny/test-reporter@v1
+      if: always()
+      with:
+        name: Load Test report on GitHub
+        path: '**/surefire-reports/TEST-*.xml'
+        reporter: java-junit
+        only-summary: 'false'
+        token: ${{ secrets.GITHUB_TOKEN }}
     - name: Cleanup Java Environment
       uses: ./.github/actions/cleanup-java-env
   observe_load_tests:
diff --git a/.github/workflows/spanner-pr.yml b/.github/workflows/spanner-pr.yml
@@ -48,7 +48,7 @@ concurrency:
 env:
   MAVEN_OPTS: -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.shade=error
 
-permissions: read-all
+permissions: write-all
 
 jobs:
   spotless_check:
@@ -182,7 +182,16 @@ jobs:
       with:
         name: surefire-test-results
         path: '**/surefire-reports/TEST-*.xml'
-        retention-days: 1
+        retention-days: 10
+    - name: Integration Test report on GitHub
+      uses: dorny/test-reporter@v1
+      if: always()
+      with:
+        name: Integration Test report on GitHub
+        path: '**/surefire-reports/TEST-*.xml'
+        reporter: java-junit
+        only-summary: 'false'
+        token: ${{ secrets.GITHUB_TOKEN }}
     - name: Cleanup Java Environment
       uses: ./.github/actions/cleanup-java-env
   java_load_tests_templates:
diff --git a/it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/monitoring/MonitoringClient.java b/it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/monitoring/MonitoringClient.java
@@ -437,7 +437,7 @@ public List<Long> listTimeSeriesAsLong(ListTimeSeriesRequest request) {
 
     ListTimeSeriesRequest request =
         ListTimeSeriesRequest.newBuilder()
-            .setName(projectId)
+            .setName(ProjectName.of(projectId).toString())
             .setFilter(filter)
             .setInterval(interval)
             .setAggregation(aggregation)
diff --git a/it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/pubsub/PubsubResourceManager.java b/it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/pubsub/PubsubResourceManager.java
@@ -432,7 +432,7 @@ private Double getAverageOldestUnackedMessageAge(MonitoringClient monitoringClie
     TimeInterval interval =
         TimeInterval.newBuilder()
             .setEndTime(Timestamp.newBuilder().setSeconds(Instant.now().getEpochSecond()))
-            .setStartTime(Timestamp.newBuilder().setSeconds(Instant.now().getEpochSecond() - 5))
+            .setStartTime(Timestamp.newBuilder().setSeconds(Instant.now().getEpochSecond() - 20))
             .build();
 
     String filterFormat =
diff --git a/v2/datastream-to-spanner/src/test/java/com/google/cloud/teleport/v2/templates/loadtesting/DataStreamToSpannerLTBase.java b/v2/datastream-to-spanner/src/test/java/com/google/cloud/teleport/v2/templates/loadtesting/DataStreamToSpannerLTBase.java
@@ -204,6 +204,7 @@ public void getResourceManagerMetrics(Map<String, Double> metrics) {
   @After
   public void cleanUp() throws IOException {
     ResourceManagerUtils.cleanResources(
+        secretClient,
         spannerResourceManager,
         pubsubResourceManager,
         gcsResourceManager,
