Skip to content

Adding MIR PR approvals requirement to CODEOWNERS #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025

Conversation

rkratky
Copy link
Collaborator

@rkratky rkratky commented Jun 3, 2025

$subj

DO NOT MERGE before #37

@rkratky rkratky requested a review from s-makin as a code owner June 3, 2025 12:39
@rkratky rkratky added the enhancement New feature or request label Jun 3, 2025
@rkratky
Copy link
Collaborator Author

rkratky commented Jun 3, 2025

Just realized... we should pbbly add CODEOWNERS itself to the team ownership.

Copy link
Collaborator

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@s-makin s-makin merged commit 4e74367 into ubuntu:main Jun 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants