Skip to content

steam_support: allow media, mnt, run/media, opt, and srv #13053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

ashuntu
Copy link
Contributor

@ashuntu ashuntu commented Aug 1, 2023

Added various /opt/, /srv/, /media/, /mnt/, /run/media/ Steam mount points as per the request here. Additional mount points were added beyond that request as new failures arose during testing.

These allow users of the Steam snap to store their libraries on external drives and properly use them.

@ashuntu ashuntu changed the title Allow media, mnt, run/media, opt, and srv steam_support: Allow media, mnt, run/media, opt, and srv Aug 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Merging #13053 (b15d3b1) into master (4cab726) will increase coverage by 0.04%.
Report is 66 commits behind head on master.
The diff coverage is 78.15%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master   #13053      +/-   ##
==========================================
+ Coverage   78.69%   78.74%   +0.04%     
==========================================
  Files         999     1002       +3     
  Lines      123909   124743     +834     
==========================================
+ Hits        97511    98224     +713     
- Misses      20265    20359      +94     
- Partials     6133     6160      +27     
Flag Coverage Δ
unittests 78.74% <78.15%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/snap/cmd_pack.go 86.66% <ø> (ø)
daemon/api_model.go 79.45% <ø> (-1.00%) ⬇️
interfaces/builtin/kvm.go 93.02% <0.00%> (ø)
interfaces/builtin/steam_support.go 100.00% <ø> (ø)
interfaces/seccomp/backend.go 83.26% <0.00%> (+1.04%) ⬆️
overlord/assertstate/assertstate.go 76.76% <0.00%> (ø)
overlord/configstate/configcore/netplan.go 9.37% <0.00%> (-0.15%) ⬇️
overlord/snapstate/flags.go 100.00% <ø> (ø)
usersession/agent/rest_api.go 0.00% <0.00%> (ø)
overlord/snapstate/storehelpers.go 77.00% <62.50%> (-0.87%) ⬇️
... and 31 more

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pedronis pedronis added the Needs security review Can only be merged once security gave a :+1: label Aug 2, 2023
@pedronis pedronis changed the title steam_support: Allow media, mnt, run/media, opt, and srv steam_support: allow media, mnt, run/media, opt, and srv Aug 2, 2023
@ashuntu ashuntu marked this pull request as ready for review August 3, 2023 18:29
@pedronis pedronis added this to the 2.61 milestone Aug 4, 2023
Copy link
Contributor

@alexmurray alexmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmurray alexmurray removed the Needs security review Can only be merged once security gave a :+1: label Aug 29, 2023
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@mvo5 mvo5 added the Squash-merge Please squash this PR when merging. label Sep 1, 2023
@mvo5 mvo5 merged commit d8942e6 into canonical:master Sep 1, 2023
alexmurray pushed a commit to alexmurray/snapd that referenced this pull request Oct 17, 2023
…3053)

* Allow media, mnt, run/media, opt, and srv

* Fix opt and srv; Add usr/etc paths

* Add ld library mount paths

* Broaden and simplify mount
fredldotme pushed a commit to fredldotme/snapd that referenced this pull request Jun 4, 2024
…3053)

* Allow media, mnt, run/media, opt, and srv

* Fix opt and srv; Add usr/etc paths

* Add ld library mount paths

* Broaden and simplify mount
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Squash-merge Please squash this PR when merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants