Add unit and spread tests for the .NET (v2) plugin #5534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mateusrodrigues, I just did a big update to |
mateusrodrigues
force-pushed
the
work/dotnet-spread-tests
branch
from
8b3c1aa to
18c71f0
Compare
mateusrodrigues
changed the title
mateusrodrigues
changed the title
mateusrodrigues
force-pushed
the
work/dotnet-spread-tests
branch
from
5be0900 to
48df665
Compare
* Remove the `dotnet-unregistered` spread test, which no longer
applies.
* Add a `dotnet-hello` spread tests that builds a simple Hello World
.NET snap with the new .NET (v2) plugin.
* Remove the `test_application_dotnet_not_registered` test and add
`core24` test cases to the `test_application_dotnet_registered`
test, since the .NET plugin is now available on core24 and later.
mateusrodrigues
force-pushed
the
work/dotnet-spread-tests
branch
from
48df665 to
6b19ab1
Compare
|
@mr-cal thanks, I rebased and fixed test failures, all checks are green now. Marking this as ready for review. |
mateusrodrigues
force-pushed
the
work/dotnet-spread-tests
branch
from
5e9848e to
f0ef178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint?make test?dotnet-unregisteredspread test, which no longer applies now that there is a new .NET plugin registered for core24.test_application_dotnet_not_registeredtest and addedcore24test cases to thetest_application_dotnet_registeredtest, since the .NET plugin is now available oncore24and later.dotnet-hellospread test that builds a simple Hello World .NET snap using the new .NET (v2) plugin to the already existingbuild-and-run-hellotest suite.