Add Snap support for portals #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
ashuntu
added a commit
to ashuntu/xdg-desktop-portal
that referenced
this pull request
Oct 12, 2023
Validates that pids are owned by Snaps, allowing them to be mapped and passed through to a portal interface; Snaps were previously denied pid mapping. Initially created to allow GameMode to use the portal dbus from within a snap: FeralInteractive/gamemode#385
This was referenced Oct 12, 2023
ashuntu
added a commit
to canonical/steam-snap
that referenced
this pull request
Oct 30, 2024
Updates GameMode to use the original repository instead of my fork since [my fix](FeralInteractive/gamemode#385) has been published in GameMode since [release 1.8](https://github.com/FeralInteractive/gamemode/releases/tag/1.8).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows GameMode to call the portal dbus as opposed to daemon dbus when inside a Snap environment, the same as with Flatpak. This way, GameMode can be properly included in Snaps and used with a portal interface.
See also: flatpak/xdg-desktop-portal#882